Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] sc-31711 Piperider run support no database connection #842

Merged
merged 7 commits into from
Aug 17, 2023
Merged

[Feature] sc-31711 Piperider run support no database connection #842

merged 7 commits into from
Aug 17, 2023

Conversation

kentwelcome
Copy link
Member

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Feature

What this PR does / why we need it:

  • Piperider run command support no database connection

Which issue(s) this PR fixes:
sc-31711

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #842 (3485316) into main (6145f63) will decrease coverage by 0.17%.
The diff coverage is 17.34%.

❗ Current head 3485316 differs from pull request most recent head efede44. Consider uploading reports for the commit efede44 to get more accurate results

@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
- Coverage   45.27%   45.10%   -0.17%     
==========================================
  Files          70       70              
  Lines        9794     9852      +58     
==========================================
+ Hits         4434     4444      +10     
- Misses       5360     5408      +48
Files Changed Coverage Δ
piperider_cli/cli.py 63.91% <0.00%> (-0.17%) ⬇️
piperider_cli/profiler/profiler.py 72.13% <8.00%> (-2.00%) ⬇️
piperider_cli/runner.py 20.40% <12.96%> (+0.19%) ⬆️
piperider_cli/cloud_connector.py 14.83% <22.22%> (-0.13%) ⬇️
piperider_cli/datasource/__init__.py 55.26% <60.00%> (-0.12%) ⬇️
piperider_cli/compare_report.py 29.85% <75.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kentwelcome kentwelcome marked this pull request as ready for review August 16, 2023 06:48
@kentwelcome kentwelcome requested a review from qrtt1 August 17, 2023 01:44
@kentwelcome kentwelcome merged commit a097530 into main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qrtt1 qrtt1 qrtt1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kentwelcome @qrtt1